• 
      

    Use the new avatar rendering for the User Selector widget.

    Review Request #10517 — Created April 4, 2019 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    The User Selector widget wasn't updated for the new avatar rendering
    support recently added to Djblets. This change updates the widget to
    supply initial rendered avatars, and for the user API queries to request
    avatars as well.

    The one annoying bit is that form field widgets have no access to the
    current HTTP request, so Djblets's avatars support had to be updated to
    make this optional. This got us most of the way, but we access the
    request in one of the avatar templates to determine if we can provide
    the user's full name in the tag. Our template tag for this has been
    updated to make the request optional in this case.

    Tested with the User Selector with users having different avatars.
    Verified that the right avatars were all shown for any initially-loaded
    users in the list, for any auto-completed entries when looking up users,
    and for any users added into the list.

    Summary ID
    Use the new avatar rendering for the User Selector widget.
    The User Selector widget wasn't updated for the new avatar rendering support recently added to Djblets. This change updates the widget to supply initial rendered avatars, and for the user API queries to request avatars as well. The one annoying bit is that form field widgets have no access to the current HTTP request, so Djblets's avatars support had to be updated to make this optional. This got us most of the way, but we access the request in one of the avatar templates to determine if we can provide the user's full name in the tag. Our template tag for this has been updated to make the request optional in this case.
    a802ca56d3b91de36f71a99eba4adbc05e25fb4f
    Description From Last Updated

    I'm not sure if it's something changeable at this point but it would be great to have this be avatarHTML

    daviddavid
    david
    1. 
        
    2. Show all issues

      I'm not sure if it's something changeable at this point but it would be great to have this be avatarHTML

      1. Totally is. I'll make the change.

    3. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (3838d32)