Summary

Remove deprecated signatures for SCMTool.get_file and file_exists.

Review Request #10505 — Created April 3, 2019 and submitted May 17, 2019, 2:15 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

SCMTool.get_file() and SCMTool.file_exists() gained the addition of

a base_commit_id many releases ago, and when that happened we needed

to deprecate the old signature and warn if used, but continue to support

it.
This change removes support for the deprecated signatures, which is long

overdue but also helps with Python 3 compatibility (as the function we

were using to check was also deprecated in Python 3).

Testing Done

Unit tests pass.

Commits

Summary	ID
Remove deprecated signatures for SCMTool.get_file and file_exists. `SCMTool.get_file()` and `SCMTool.file_exists()` gained the addition of a `base_commit_id` many releases ago, and when that happened we needed to deprecate the old signature and warn if used, but continue to support it. This change removes support for the deprecated signatures, which is long overdue but also helps with Python 3 compatibility (as the function we were using to check was also deprecated in Python 3).	7eb96d3406714de9b46cbf3f67b39639a5da3c9f

Summary

Remove deprecated signatures for SCMTool.get_file and file_exists.

`SCMTool.get_file()` and `SCMTool.file_exists()` gained the addition of a `base_commit_id` many releases ago, and when that happened we needed to deprecate the old signature and warn if used, but continue to support it. This change removes support for the deprecated signatures, which is long overdue but also helps with Python 3 compatibility (as the function we were using to check was also deprecated in Python 3).

7eb96d3406714de9b46cbf3f67b39639a5da3c9f

flake8 passed.

JSHint passed.

Change Summary:

Removed one more deprecation check.

Commits:

	Summary	ID
	Remove deprecated signatures for SCMTool.get_file and file_exists. `SCMTool.get_file()` and `SCMTool.file_exists()` gained the addition of a `base_commit_id` many releases ago, and when that happened we needed to deprecate the old signature and warn if used, but continue to support it. This change removes support for the deprecated signatures, which is long overdue but also helps with Python 3 compatibility (as the function we were using to check was also deprecated in Python 3).	fcfe6be7fd85d40a19b5323c5d59e5dfb9bb259b
	Remove deprecated signatures for SCMTool.get_file and file_exists. `SCMTool.get_file()` and `SCMTool.file_exists()` gained the addition of a `base_commit_id` many releases ago, and when that happened we needed to deprecate the old signature and warn if used, but continue to support it. This change removes support for the deprecated signatures, which is long overdue but also helps with Python 3 compatibility (as the function we were using to check was also deprecated in Python 3).	7eb96d3406714de9b46cbf3f67b39639a5da3c9f

Diff:

Revision 2 (+10 -140)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/models.py
	reviewboard/scmtools/tests/test_repository.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (0eea052)