Remove deprecated signatures for SCMTool.get_file and file_exists.

Review Request #10505 — Created April 3, 2019 and updated

chipx86
Review Board
release-4.0.x
reviewboard

SCMTool.get_file() and SCMTool.file_exists() gained the addition of
a base_commit_id many releases ago, and when that happened we needed
to deprecate the old signature and warn if used, but continue to support
it.

This change removes support for the deprecated signatures, which is long
overdue but also helps with Python 3 compatibility (as the function we
were using to check was also deprecated in Python 3).

Unit tests pass.

Summary
Remove deprecated signatures for SCMTool.get_file and file_exists.
chipx86
Review request changed

Change Summary:

Removed one more deprecation check.

Commits:

Summary
-
Remove deprecated signatures for SCMTool.get_file and file_exists.
+
Remove deprecated signatures for SCMTool.get_file and file_exists.

Diff:

Revision 2 (+10 -140)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
Loading...