Remove deprecated signatures for SCMTool.get_file and file_exists.

Review Request #10505 — Created April 3, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

SCMTool.get_file() and SCMTool.file_exists() gained the addition of
a base_commit_id many releases ago, and when that happened we needed
to deprecate the old signature and warn if used, but continue to support
it.

This change removes support for the deprecated signatures, which is long
overdue but also helps with Python 3 compatibility (as the function we
were using to check was also deprecated in Python 3).

Unit tests pass.

Summary ID
Remove deprecated signatures for SCMTool.get_file and file_exists.
`SCMTool.get_file()` and `SCMTool.file_exists()` gained the addition of a `base_commit_id` many releases ago, and when that happened we needed to deprecate the old signature and warn if used, but continue to support it. This change removes support for the deprecated signatures, which is long overdue but also helps with Python 3 compatibility (as the function we were using to check was also deprecated in Python 3).
7eb96d3406714de9b46cbf3f67b39639a5da3c9f
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (0eea052)