Normalize environment variables when calling SCMTool.popen.

 






 

 


  Review Request #10504
  —
  Created April 3, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This updates SCMTool.popen() to convert all environment variables that

are passed into native strings, suitable for both Python 2.x and 3.x.

This simplifies callers and ensures compatibility.

 








  


 
 

  
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

 







 









 





  








 




 







   

    
    

    

    


    

      
Commits

      

        
      

    


    


      
Files