Normalize environment variables when calling SCMTool.popen.

Review Request #10504 — Created April 3, 2019 and updated

chipx86
Review Board
release-4.0.x
reviewboard

This updates SCMTool.popen() to convert all environment variables that
are passed into native strings, suitable for both Python 2.x and 3.x.
This simplifies callers and ensures compatibility.

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Summary
Normalize environment variables when calling SCMTool.popen.
Description From Last Updated

Do we want the keys to be str?

daviddavid
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. 
      
  2. reviewboard/scmtools/bzr/__init__.py (Diff revision 1)
     
     
     
     

    Do we want the keys to be str?

    1. Nope, this is handled in the popen wrapper. Callers no longer need to care (avoids subtle breakages).

  3. 
      
david
  1. Ship It!
  2. 
      
Loading...