Normalize environment variables when calling SCMTool.popen.

Review Request #10504 — Created April 3, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

This updates SCMTool.popen() to convert all environment variables that
are passed into native strings, suitable for both Python 2.x and 3.x.
This simplifies callers and ensures compatibility.

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Summary ID
Normalize environment variables when calling SCMTool.popen.
This updates `SCMTool.popen()` to convert all environment variables that are passed into native strings, suitable for both Python 2.x and 3.x. This simplifies callers and ensures compatibility.
b75aebe1d23f3c50136ab71c4463ba82fc259772
Description From Last Updated

Do we want the keys to be str?

daviddavid
david
  1. 
      
  2. reviewboard/scmtools/bzr/__init__.py (Diff revision 1)
     
     
     
     
    Show all issues

    Do we want the keys to be str?

    1. Nope, this is handled in the popen wrapper. Callers no longer need to care (avoids subtle breakages).

  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (5effe13)