Summary

Ensure Unicode arguments for file fetching and bytes for results.

Review Request #10503 — Created April 3, 2019 and submitted May 17, 2019, 2:15 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This adds some type safety for Repository.get_file() and
Repository.get_file_exists(), ensuring that the arguments coming in
are all Unicode strings. It then checks that the results from the
hosting service or SCMTool are bytes. This ensures we're always working
with the data types we're expecting.

This required some fixes in a few of the hosting services and SCMTools,
casting string types for comparisons and for the results.

Testing Done

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Commits

Summary	ID
Ensure Unicode arguments for file fetching and bytes for results. This adds some type safety for `Repository.get_file()` and `Repository.get_file_exists()`, ensuring that the arguments coming in are all Unicode strings. It then checks that the results from the hosting service or SCMTool are bytes. This ensures we're always working with the data types we're expecting. This required some fixes in a few of the hosting services and SCMTools, casting string types for comparisons and for the results.	a1827ab8315fb9dab0ff169f999431d5bb1760c8

Summary

Ensure Unicode arguments for file fetching and bytes for results.

This adds some type safety for `Repository.get_file()` and `Repository.get_file_exists()`, ensuring that the arguments coming in are all Unicode strings. It then checks that the results from the hosting service or SCMTool are bytes. This ensures we're always working with the data types we're expecting. This required some fixes in a few of the hosting services and SCMTools, casting string types for comparisons and for the results.

a1827ab8315fb9dab0ff169f999431d5bb1760c8

Issues

Description	From	Last Updated
F841 local variable 'tool' is assigned to but never used	reviewbot	April 3, 2019, 12:50 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'tool' is assigned to but never used
```

Change Summary:

Fixed an unused variable.

Commits:

	Summary	ID
	Ensure Unicode arguments for file fetching and bytes for results. This adds some type safety for `Repository.get_file()` and `Repository.get_file_exists()`, ensuring that the arguments coming in are all Unicode strings. It then checks that the results from the hosting service or SCMTool are bytes. This ensures we're always working with the data types we're expecting. This required some fixes in a few of the hosting services and SCMTools, casting string types for comparisons and for the results.	619df4a25761d7336b3412f228c52e1933340e88
	Ensure Unicode arguments for file fetching and bytes for results. This adds some type safety for `Repository.get_file()` and `Repository.get_file_exists()`, ensuring that the arguments coming in are all Unicode strings. It then checks that the results from the hosting service or SCMTool are bytes. This ensures we're always working with the data types we're expecting. This required some fixes in a few of the hosting services and SCMTools, casting string types for comparisons and for the results.	a1827ab8315fb9dab0ff169f999431d5bb1760c8

Diff:

Revision 2 (+344 -188)

Show changes

	reviewboard/hostingsvcs/beanstalk.py
	reviewboard/hostingsvcs/kiln.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/cvs.py
	reviewboard/scmtools/git.py
	reviewboard/scmtools/models.py
	reviewboard/scmtools/bzr/__init__.py
	reviewboard/scmtools/tests/test_cvs.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (91c3616)