Fish Trophy

  
chipx86 got a fish trophy!

  
  Fish Trophy

 







 





 

 

  

  

 




  







 




  


 
 

  
Update remaining diff viewer code for Python 3.

 






 

 


  Review Request #10501
  —
  Created April 2, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This updates some remaining bits of code in the diff viewer to work with

both Python 2 and 3. This involves:


    

  1. 

    Switching to alternative methods for chunk building (working around
    
   behavioral changes in map and partial)
    

    2. 

  2. 

    Removing usage of StopIteration (which no longer behaves the same
    
   way and is deprecated)
    

    3. 

  3. 

    Fixing a comparison between a string and an integer in chunk
    
   generation.
    

    4. 

  4. 

    Fixing the building of strings and other data in tests to get the
    
   correct types and to work with Python 3's formatting restrictions.
    

    5. 


 








  


 
 

  
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update remaining diff viewer code for Python 3.
     
This updates some remaining bits of code in the diff viewer to work with
both Python 2 and 3. This involves:

1. Switching to alternative methods for chunk building (working around
   behavioral changes in `map` and `partial`)

2. Removing usage of `StopIteration` (which no longer behaves the same
   way and is deprecated)

3. Fixing a comparison between a string and an integer in chunk
   generation.

4. Fixing the building of strings and other data in tests to get the
   correct types and to work with Python 3's formatting restrictions.

    

   
  		
  00050ed1abb8b9328ca0f70ca92a2c2de8834e83
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/diffutils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_processors.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...