chipx86 got a fish trophy!

Summary

Update remaining diff viewer code for Python 3.

Review Request #10501 — Created April 2, 2019 and submitted May 17, 2019, 2:15 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates some remaining bits of code in the diff viewer to work with
both Python 2 and 3. This involves:

Switching to alternative methods for chunk building (working around
behavioral changes in map and partial)
Removing usage of StopIteration (which no longer behaves the same
way and is deprecated)
Fixing a comparison between a string and an integer in chunk
generation.
Fixing the building of strings and other data in tests to get the
correct types and to work with Python 3's formatting restrictions.

Testing Done

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Commits

Summary	ID
Update remaining diff viewer code for Python 3. This updates some remaining bits of code in the diff viewer to work with both Python 2 and 3. This involves: 1. Switching to alternative methods for chunk building (working around behavioral changes in `map` and `partial`) 2. Removing usage of `StopIteration` (which no longer behaves the same way and is deprecated) 3. Fixing a comparison between a string and an integer in chunk generation. 4. Fixing the building of strings and other data in tests to get the correct types and to work with Python 3's formatting restrictions.	1c4e523d608e1e4e7044a814383fd86acc1f796b

Summary

Update remaining diff viewer code for Python 3.

This updates some remaining bits of code in the diff viewer to work with both Python 2 and 3. This involves: 1. Switching to alternative methods for chunk building (working around behavioral changes in `map` and `partial`) 2. Removing usage of `StopIteration` (which no longer behaves the same way and is deprecated) 3. Fixing a comparison between a string and an integer in chunk generation. 4. Fixing the building of strings and other data in tests to get the correct types and to work with Python 3's formatting restrictions.

1c4e523d608e1e4e7044a814383fd86acc1f796b

Issues

Description	From	Last Updated
F821 undefined name 'force_text'	reviewbot	April 2, 2019, 9:24 p.m.
Can you fix up this docstring while you're in here?	david	April 10, 2019, 4:53 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'force_text'
```

Change Summary:

Added a missing import that wasn't staged for commit.

Commits:

	Summary	ID
	Update remaining diff viewer code for Python 3. This updates some remaining bits of code in the diff viewer to work with both Python 2 and 3. This involves: 1. Switching to alternative methods for chunk building (working around behavioral changes in `map` and `partial`) 2. Removing usage of `StopIteration` (which no longer behaves the same way and is deprecated) 3. Fixing a comparison between a string and an integer in chunk generation. 4. Fixing the building of strings and other data in tests to get the correct types and to work with Python 3's formatting restrictions.	00050ed1abb8b9328ca0f70ca92a2c2de8834e83
	Update remaining diff viewer code for Python 3. This updates some remaining bits of code in the diff viewer to work with both Python 2 and 3. This involves: 1. Switching to alternative methods for chunk building (working around behavioral changes in `map` and `partial`) 2. Removing usage of `StopIteration` (which no longer behaves the same way and is deprecated) 3. Fixing a comparison between a string and an integer in chunk generation. 4. Fixing the building of strings and other data in tests to get the correct types and to work with Python 3's formatting restrictions.	1c4e523d608e1e4e7044a814383fd86acc1f796b

Diff:

Revision 2 (+100 -56)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/diffviewer/tests/test_processors.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/diffviewer/chunk_generator.py (Diff revision 2)

The issue has been dropped. Show all issues

Can you fix up this docstring while you're in here?

chipx86 April 10, 2019, 4:16 p.m.

I'd like to do some doc cleanup work, but there's a lot more than just this that needs love. Since no arguments were changed here, I'd rather do this in a separate doc cleanup change.

david April 10, 2019, 4:30 p.m.
```
Sure.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (5daca0d)