• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Update remaining diff viewer code for Python 3.

    Review Request #10501 — Created April 3, 2019 and submitted — Latest diff uploaded

    Information

    Review Board
    release-4.0.x

    Reviewers

    This updates some remaining bits of code in the diff viewer to work with
    both Python 2 and 3. This involves:

    1. Switching to alternative methods for chunk building (working around
      behavioral changes in map and partial)

    2. Removing usage of StopIteration (which no longer behaves the same
      way and is deprecated)

    3. Fixing a comparison between a string and an integer in chunk
      generation.

    4. Fixing the building of strings and other data in tests to get the
      correct types and to work with Python 3's formatting restrictions.

    Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

    Commits

    Files