Require diffs set on a FileDiff to be byte strings.

 






 

 


  Review Request #10499
  —
  Created April 3, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
FileDiff was previously allowing either byte strings or Unicode

strings, which created inconsistency. We now require byte strings, and

check for this when creating a FileDiff from data.

 








  


 
 

  
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Require diffs set on a FileDiff to be byte strings.
     
`FileDiff` was previously allowing either byte strings or Unicode
strings, which created inconsistency. We now require byte strings, and
check for this when creating a `FileDiff` from data.

    

   
  		
  700794ecf2f5309a5554d3d9451a54d84549c716
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffutils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_filediff_migration.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/notifications/tests/test_email_sending.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...