Summary

Require diffs set on a FileDiff to be byte strings.

Review Request #10499 — Created April 3, 2019 and submitted May 17, 2019, 2:15 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

FileDiff was previously allowing either byte strings or Unicode
strings, which created inconsistency. We now require byte strings, and
check for this when creating a FileDiff from data.

Testing Done

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Commits

Summary	ID
Require diffs set on a FileDiff to be byte strings. `FileDiff` was previously allowing either byte strings or Unicode strings, which created inconsistency. We now require byte strings, and check for this when creating a `FileDiff` from data.	700794ecf2f5309a5554d3d9451a54d84549c716

Issues

Description	From	Last Updated
This doesn't seem like something that should be localized.	david	April 10, 2019, 4:14 p.m.

flake8 passed.

JSHint passed.

reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This doesn't seem like something that should be localized.
```

Change Summary:

Removed localization of an error.

Commits:

	Summary	ID
	Require diffs set on a FileDiff to be byte strings. `FileDiff` was previously allowing either byte strings or Unicode strings, which created inconsistency. We now require byte strings, and check for this when creating a `FileDiff` from data.	6ab3a57099b393822bcac4ff5ba27ddf7d690e07
	Require diffs set on a FileDiff to be byte strings. `FileDiff` was previously allowing either byte strings or Unicode strings, which created inconsistency. We now require byte strings, and check for this when creating a `FileDiff` from data.	700794ecf2f5309a5554d3d9451a54d84549c716

Diff:

Revision 2 (+240 -200)

Show changes

	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models/filediff.py
	reviewboard/diffviewer/tests/test_diffutils.py
	reviewboard/diffviewer/tests/test_filediff_migration.py
	reviewboard/notifications/tests/test_email_sending.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (335da98)