Require diffs set on a FileDiff to be byte strings.

Review Request #10499 — Created April 3, 2019 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

FileDiff was previously allowing either byte strings or Unicode
strings, which created inconsistency. We now require byte strings, and
check for this when creating a FileDiff from data.

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Summary
Require diffs set on a FileDiff to be byte strings.
Description From Last Updated

This doesn't seem like something that should be localized.

daviddavid
david
  1. 
      
  2. reviewboard/diffviewer/managers.py (Diff revision 1)
     
     
     

    This doesn't seem like something that should be localized.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (335da98)
Loading...