Require diffs set on a FileDiff to be byte strings.
Review Request #10499 — Created April 3, 2019 and submitted — Latest diff uploaded
FileDiffwas previously allowing either byte strings or Unicode
strings, which created inconsistency. We now require byte strings, and
check for this when creating aFileDifffrom data.
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.
orig
1
2
Commits
| reviewboard/diffviewer/managers.py |
|---|
| reviewboard/diffviewer/models/filediff.py |
|---|
| reviewboard/diffviewer/tests/test_diffutils.py |
|---|
| reviewboard/diffviewer/tests/test_filediff_migration.py |
|---|
| reviewboard/notifications/tests/test_email_sending.py |
|---|