Update all uses of the legacy ParsedFileDiff attributes.

 






 

 


  Review Request #10498
  —
  Created April 2, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In a previous change, ParsedFileDiff gained some new type-safe

attributes, leaving a handful of legacy attributes in its place. This

change updates the remaining code using these attributes. These were

primarily unit tests (as few diff parsers actually modify this object

directly, but rather than an info dictionary that's processed by the

main DiffParser). However, Git has more fine-grained control of its

parsing, so it needed to be updated to ensure it was setting the new

attributes using the right types.

 








  


 
 

  
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update all uses of the legacy ParsedFileDiff attributes.
     
In a previous change, `ParsedFileDiff` gained some new type-safe
attributes, leaving a handful of legacy attributes in its place. This
change updates the remaining code using these attributes. These were
primarily unit tests (as few diff parsers actually modify this object
directly, but rather than an info dictionary that's processed by the
main `DiffParser`). However, Git has more fine-grained control of its
parsing, so it needed to be updated to ensure it was setting the new
attributes using the right types.

    

   
  		
  449c90a928bd74c55dedff27b6c7f00854151d23
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/git.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_cvs.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_git.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_hg.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_perforce.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_svn.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...