Summary

Update all uses of the legacy ParsedFileDiff attributes.

Review Request #10498 — Created April 2, 2019 and submitted May 17, 2019, 2:12 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In a previous change, ParsedFileDiff gained some new type-safe
attributes, leaving a handful of legacy attributes in its place. This
change updates the remaining code using these attributes. These were
primarily unit tests (as few diff parsers actually modify this object
directly, but rather than an info dictionary that's processed by the
main DiffParser). However, Git has more fine-grained control of its
parsing, so it needed to be updated to ensure it was setting the new
attributes using the right types.

Testing Done

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Commits

Summary	ID
Update all uses of the legacy ParsedFileDiff attributes. In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.	f0fbd6a87bb557b279dbde31691ada8fcdd4f868

Summary

Update all uses of the legacy ParsedFileDiff attributes.

In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.

f0fbd6a87bb557b279dbde31691ada8fcdd4f868

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (84 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (84 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.
E501 line too long (82 > 79 characters)	reviewbot	April 2, 2019, 3:18 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```

Change Summary:

Fixed line length issues.

Commits:

	Summary	ID
	Update all uses of the legacy ParsedFileDiff attributes. In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.	1ac5ec024381be919b1a3a92fff07c6c36930e12
	Update all uses of the legacy ParsedFileDiff attributes. In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.	449c90a928bd74c55dedff27b6c7f00854151d23

Diff:

Revision 2 (+570 -540)

Show changes

	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests/test_cvs.py
	reviewboard/scmtools/tests/test_git.py
	reviewboard/scmtools/tests/test_hg.py
	reviewboard/scmtools/tests/test_perforce.py
	reviewboard/scmtools/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Revision is now converted to bytes before calling parse_diff_revision().

Commits:

	Summary	ID
	Update all uses of the legacy ParsedFileDiff attributes. In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.	449c90a928bd74c55dedff27b6c7f00854151d23
	Update all uses of the legacy ParsedFileDiff attributes. In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.	f0fbd6a87bb557b279dbde31691ada8fcdd4f868

Diff:

Revision 3 (+580 -542)

Show changes

	reviewboard/diffviewer/filediff_creator.py
	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests/test_cvs.py
	reviewboard/scmtools/tests/test_git.py
	reviewboard/scmtools/tests/test_hg.py
	reviewboard/scmtools/tests/test_perforce.py
	reviewboard/scmtools/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (8899b7d)