Update all uses of the legacy ParsedFileDiff attributes.
Review Request #10498 — Created April 2, 2019 and submitted
In a previous change,
ParsedFileDiff
gained some new type-safe
attributes, leaving a handful of legacy attributes in its place. This
change updates the remaining code using these attributes. These were
primarily unit tests (as few diff parsers actually modify this object
directly, but rather than an info dictionary that's processed by the
mainDiffParser
). However, Git has more fine-grained control of its
parsing, so it needed to be updated to ensure it was setting the new
attributes using the right types.
Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).
Summary | ID |
---|---|
f0fbd6a87bb557b279dbde31691ada8fcdd4f868 |
Description | From | Last Updated |
---|---|---|
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (84 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (84 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot |
- Change Summary:
-
Fixed line length issues.
- Commits:
-
Summary ID 1ac5ec024381be919b1a3a92fff07c6c36930e12 449c90a928bd74c55dedff27b6c7f00854151d23
Checks run (2 succeeded)
- Change Summary:
-
Revision
is now converted tobytes
before callingparse_diff_revision()
. - Commits:
-
Summary ID 449c90a928bd74c55dedff27b6c7f00854151d23 f0fbd6a87bb557b279dbde31691ada8fcdd4f868 - Diff:
-
Revision 3 (+580 -542)