Update all uses of the legacy ParsedFileDiff attributes.

Review Request #10498 — Created April 2, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

In a previous change, ParsedFileDiff gained some new type-safe
attributes, leaving a handful of legacy attributes in its place. This
change updates the remaining code using these attributes. These were
primarily unit tests (as few diff parsers actually modify this object
directly, but rather than an info dictionary that's processed by the
main DiffParser). However, Git has more fine-grained control of its
parsing, so it needed to be updated to ensure it was setting the new
attributes using the right types.

Unit tests pass on Python 2.7 and 3.7 (with other in-progress changes).

Summary ID
Update all uses of the legacy ParsedFileDiff attributes.
In a previous change, `ParsedFileDiff` gained some new type-safe attributes, leaving a handful of legacy attributes in its place. This change updates the remaining code using these attributes. These were primarily unit tests (as few diff parsers actually modify this object directly, but rather than an info dictionary that's processed by the main `DiffParser`). However, Git has more fine-grained control of its parsing, so it needed to be updated to ensure it was setting the new attributes using the right types.
f0fbd6a87bb557b279dbde31691ada8fcdd4f868
Description From Last Updated

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (82 > 79 characters)

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (8899b7d)