-
-
rbtools/postreview.py (Diff revision 1) Should actually be all on one line, like """Perform blah blah"""
-
-
-
rbtools/postreview.py (Diff revision 1) General comment with this function. You're using 2 space indentation. It needs to be 4 spaces.
-
-
-
-
[post-review] support "revision-range" option with git
Review Request #1049 — Created Sept. 14, 2009 and submitted
Information | |
---|---|
flavio | |
RBTools | |
Reviewers | |
reviewboard | |
With this patch post-review will support the revision-range option following the syntax explained here [1]. [1] http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-committed-code
I have tested this new feature locally and it works fine. I have successfully tested the following commands: post-review --revision-range=rev1:rev2 --guess-summary --guess-description post-review --revision-range=rev1:rev2 --guess-description post-review --revision-range=rev1:rev2 post-review --revision-range=rev --guess-summary --guess-description post-review --revision-range=rev
-
The diff you uploaded seems to be relative to your first one, and therefore doesn't show up here in RB. Can you post one against origin/master?