Summary

[post-review] support "revision-range" option with git

Review Request #1049 — Created Sept. 14, 2009 and submitted

Information

Owner

flavio

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

With this patch post-review will support the revision-range option following the syntax explained here [1].

[1] http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-committed-code

Testing Done

I have tested this new feature locally and it works fine.

I have successfully tested the following commands:
post-review --revision-range=rev1:rev2 --guess-summary --guess-description
post-review --revision-range=rev1:rev2 --guess-description
post-review --revision-range=rev1:rev2
post-review --revision-range=rev --guess-summary --guess-description
post-review --revision-range=rev

rbtools/postreview.py (Diff revision 1)

Should actually be all on one line, like """Perform blah blah"""

rbtools/postreview.py (Diff revision 1)
```
Remove the blank line.
```

rbtools/postreview.py (Diff revision 1)

Can be:

    if ":" not in revision_range:

rbtools/postreview.py (Diff revision 1)

General comment with this function. You're using 2 space indentation. It needs to be 4 spaces.

rbtools/postreview.py (Diff revision 1)
```
Does this wrap to 80 characters?
```

rbtools/postreview.py (Diff revision 1)

Replace r1+".."+r2 with "%s..%s" % (r1, r2).

rbtools/postreview.py (Diff revision 1)
```
Here too.
```
rbtools/postreview.py (Diff revision 1)
```
Remove this blank line.
```

Change Summary:

I have changed the code as you suggested.

Diff:

Revision 2 (+18 -22)

Show changes

rbtools/postreview.py

The diff you uploaded seems to be relative to your first one, and therefore doesn't show up here in RB. Can you post one against origin/master?

Change Summary:

I have uploaded the right diff file (I hope)

Diff:

Revision 3 (+26 -1)

Show changes

rbtools/postreview.py