Update the related object widgets for some Django 1.11 changes.

Review Request #10486 — Created April 1, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

The related object widgets call build_attrs in order to create some
attributes to pass into the HTML for the widgets. Django's changed the
signature for this method since Django 1.6, which led to some crashes
during rendering.

The function itself is really simple in its purpose, so rather than
working around the changes, we just build the attributes dictionary in
the widget directly, fixing that compatibility problem.

Unit tests pass on Django 1.6 and 1.11 (with other in-progress changes).

Summary ID
Update the related object widgets for some Django 1.11 changes.
The related object widgets call `build_attrs` in order to create some attributes to pass into the HTML for the widgets. Django's changed the signature for this method since Django 1.6, which led to some crashes during rendering. The function itself is really simple in its purpose, so rather than working around the changes, we just build the attributes dictionary in the widget directly, fixing that compatibility problem.
3425f8a3e6333c8d9f4337003c4f0fbb756bc95e
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (e70958c)
Loading...