Summary

Update the related object widgets for some Django 1.11 changes.

Review Request #10486 — Created April 1, 2019 and submitted April 10, 2019, 8:41 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The related object widgets call build_attrs in order to create some

attributes to pass into the HTML for the widgets. Django's changed the

signature for this method since Django 1.6, which led to some crashes

during rendering.
The function itself is really simple in its purpose, so rather than

working around the changes, we just build the attributes dictionary in

the widget directly, fixing that compatibility problem.

Testing Done

Unit tests pass on Django 1.6 and 1.11 (with other in-progress changes).

Commits

Summary	ID
Update the related object widgets for some Django 1.11 changes. The related object widgets call `build_attrs` in order to create some attributes to pass into the HTML for the widgets. Django's changed the signature for this method since Django 1.6, which led to some crashes during rendering. The function itself is really simple in its purpose, so rather than working around the changes, we just build the attributes dictionary in the widget directly, fixing that compatibility problem.	3425f8a3e6333c8d9f4337003c4f0fbb756bc95e

Summary

Update the related object widgets for some Django 1.11 changes.

The related object widgets call `build_attrs` in order to create some attributes to pass into the HTML for the widgets. Django's changed the signature for this method since Django 1.6, which led to some crashes during rendering. The function itself is really simple in its purpose, so rather than working around the changes, we just build the attributes dictionary in the widget directly, fixing that compatibility problem.

3425f8a3e6333c8d9f4337003c4f0fbb756bc95e

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (e70958c)