Summary

Fix regressions from the json_dumps sorting change.

Review Request #10484 — Created April 1, 2019 and submitted April 10, 2019, 8:40 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The recent change to json_dumps in Djblets to sort keys broke a couple
of unit tests in Review Board, which hard-coded results using the old
ordering. This is a simple change that updates the tests to compare
against the sorted payloads.

Testing Done

Unit tests pass on Django 1.6 and 1.11 (with other in-progress changes).

Commits

Summary	ID
Fix regressions from the json_dumps sorting change. The recent change to `json_dumps` in Djblets to sort keys broke a couple of unit tests in Review Board, which hard-coded results using the old ordering. This is a simple change that updates the tests to compare against the sorted payloads.	96eb0aa577d833ead48f3d27bd91cb38f5f1dc48

Issues

Description	From	Last Updated
E501 line too long (137 > 79 characters)	reviewbot	April 1, 2019, 12:11 a.m.
E501 line too long (120 > 79 characters)	reviewbot	April 1, 2019, 12:11 a.m.
E501 line too long (120 > 79 characters)	reviewbot	April 1, 2019, 12:11 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/tests.py (Diff revision 1)
Show all issues
```
E501 line too long (137 > 79 characters)
```
reviewboard/admin/tests.py (Diff revision 1)
Show all issues
```
E501 line too long (120 > 79 characters)
```
reviewboard/admin/tests.py (Diff revision 1)
Show all issues
```
E501 line too long (120 > 79 characters)
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (7f99bd1)

reviewboard/admin/tests.py (Diff revision 1)

reviewboard/admin/tests.py (Diff revision 1)

reviewboard/admin/tests.py (Diff revision 1)