Summary

Add Python 3 compatibility for rbssh.

Review Request #10475 — Created March 28, 2019 and submitted April 10, 2019, 8:52 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Python 3 changed sys.stdout and sys.stderr to require Unicode
strings, but this doesn't work so well for binary data, which rbssh
writes. Instead, we need to use the buffer attribute of both of these.

This change updates rbssh to determine the right object to write to for
Python 2 and 3. It also disables warning output, which interferes with
the communication (and is triggered quite a lot by paramiko's
interaction with cryptography).

Testing Done

rbssh-based unit tests pass on Python 2 and 3 (when used with other
pending changes).

Commits

Summary	ID
Add Python 3 compatibility for rbssh. Python 3 changed `sys.stdout` and `sys.stderr` to require Unicode strings, but this doesn't work so well for binary data, which rbssh writes. Instead, we need to use the `buffer` attribute of both of these. This change updates rbssh to determine the right object to write to for Python 2 and 3. It also disables warning output, which interferes with the communication (and is triggered quite a lot by paramiko's interaction with cryptography).	594356ecca2b743314b86c8e587285a5077ba5f6

Summary

Add Python 3 compatibility for rbssh.

Python 3 changed `sys.stdout` and `sys.stderr` to require Unicode strings, but this doesn't work so well for binary data, which rbssh writes. Instead, we need to use the `buffer` attribute of both of these. This change updates rbssh to determine the right object to write to for Python 2 and 3. It also disables warning output, which interferes with the communication (and is triggered quite a lot by paramiko's interaction with cryptography).

594356ecca2b743314b86c8e587285a5077ba5f6

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	March 28, 2019, 3:16 a.m.
E402 module level import not at top of file	reviewbot	March 28, 2019, 3:16 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbssh.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
reviewboard/cmdline/rbssh.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (9555cf1)