Remove the app_name for integration URLs.
Review Request #10472 — Created March 27, 2019 and submitted
Django 1.6 happily allows an application namespaec (
app_name
) to be
specified for any URLs, but newer 1.x versions only allow this if an
instance namespace (namespace
) is being provided. Django 2.x doesn't
allow the parameter at all, instead requiring a whole different process
for specifying the app namespace.This change removes the application namespace entirely for integration
URLs. We don't use it to resolve URLs ourselves, and callers can always
provide their own namespace, so there's not much point in keeping this
around.
Djblets and Review Board unit tests pass on Django 1.6 and 1.11.
Summary | ID |
---|---|
4ca45556cef596c28ee3dc9da9bfa2b0d4958afd |
Description | From | Last Updated |
---|---|---|
Hmm, actually, this comment is confusing (seems backwards to the code). |
david |
- Change Summary:
-
Reworked this completely to just eliminate the
app_name
parameter, for future compatibility with Django 2.0. - Summary:
-
Only specify an app_name for integration URLs when using namespaces.Remove the app_name for integration URLs.
- Description:
-
~ Django 1.6 happily allows an
app_name
parameter to be specified for~ any URLs, but newer versions only allow this if a namespace is being ~ provided. This change accounts for this, passing one only if the caller ~ has a specific namespace they want to use. ~ Django 1.6 happily allows an application namespaec (
app_name
) to be~ specified for any URLs, but newer 1.x versions only allow this if an ~ instance namespace ( namespace
) is being provided. Django 2.x doesn't~ allow the parameter at all, instead requiring a whole different process + for specifying the app namespace. + + This change removes the application namespace entirely for integration
+ URLs. We don't use it to resolve URLs ourselves, and callers can always + provide their own namespace, so there's not much point in keeping this + around. - Commits:
-
Summary ID d07359a3fb07a70a65a61ce0209edfc76f9a7187 4ca45556cef596c28ee3dc9da9bfa2b0d4958afd - Diff:
-
Revision 2 (+2 -4)