Remove the app_name for integration URLs.

Review Request #10472 — Created March 27, 2019 and submitted — Latest diff uploaded

Information

Djblets
release-2.0.x

Reviewers

Django 1.6 happily allows an application namespaec (app_name) to be
specified for any URLs, but newer 1.x versions only allow this if an
instance namespace (namespace) is being provided. Django 2.x doesn't
allow the parameter at all, instead requiring a whole different process
for specifying the app namespace.

This change removes the application namespace entirely for integration
URLs. We don't use it to resolve URLs ourselves, and callers can always
provide their own namespace, so there's not much point in keeping this
around.

Djblets and Review Board unit tests pass on Django 1.6 and 1.11.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Only specify an app_name for integration URLs when using namespaces.
Django 1.6 happily allows an `app_name` parameter to be specified for any URLs, but newer versions only allow this if a namespace is being provided. This change accounts for this, passing one only if the caller has a specific namespace they want to use.
d07359a3fb07a70a65a61ce0209edfc76f9a7187 Christian Hammond
Remove the app_name for integration URLs.
Django 1.6 happily allows an application namespaec (`app_name`) to be specified for any URLs, but newer 1.x versions only allow this if an instance namespace (`namespace`) is being provided. Django 2.x doesn't allow the parameter at all, instead requiring a whole different process for specifying the app namespace. This change removes the application namespace entirely for integration URLs. We don't use it to resolve URLs ourselves, and callers can always provide their own namespace, so there's not much point in keeping this around.
4ca45556cef596c28ee3dc9da9bfa2b0d4958afd Christian Hammond
djblets/integrations/urls.py
Loading...