Summary

Compare raw API payloads to byte strings during API testing.

Review Request #10468 — Created March 27, 2019 and submitted April 10, 2019, 4:24 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

HTTP response data is represented as byte strings, and on Python 2 we
were able to compare to either bytes or Unicode without problems, but
this isn't the case with Python 3. Our API testing helpers were
incorrectly comparing to Unicode prior to this change.

Testing Done

Djblets and Review Board unit tests pass.

Commits

Summary	ID
Compare raw API payloads to byte strings during API testing. HTTP response data is represented as byte strings, and on Python 2 we were able to compare to either bytes or Unicode without problems, but this isn't the case with Python 3. Our API testing helpers were incorrectly comparing to Unicode prior to this change.	eb2825dee4a17d211af956ab3dccdf4f7aeb8179

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1b37eea)