Finish updating rbt patch to localize and use logging for output.
Review Request #10461 — Created March 21, 2019 and updated
Information | |
---|---|
chipx86 | |
RBTools | |
master | |
Reviewers | |
rbtools | |
This finishes localizing all the strings in
rbt patch
, preparing for
a future in which we might someday offer translations. It also moves us
to using logging for all remaining output.
Tested the various conditions, making sure the output was correct.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Hmmm. I'm really not sure about using logger.info for what is fundamentally expected to be stdout output. The more I … |
|
-
-
rbtools/commands/patch.py (Diff revision 1) Hmmm. I'm really not sure about using
logger.info
for what is fundamentally expected to be stdout output.The more I work with the rbtools codebase the more I feel like regular/error output should use
print
/sys.stderr.write
andlogging
should fundamentally just be about logging.