Summary

Migrate some more code to ES6 (5).

Review Request #10455 — Created March 20, 2019 and submitted April 16, 2019, 3:05 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts all remaining test code to ES6.

Testing Done

Ran js-tests.

Commits

Summary	ID
Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	087db3eb299015557b983157d04a6d638e8044b1

Issues

Description	From	Last Updated
Col: 19 'view' is defined but never used.	reviewbot	March 20, 2019, 12:07 p.m.
Too many spaces.	chipx86	March 28, 2019, 2:20 p.m.
Col: 19 'view' is defined but never used.	reviewbot	March 22, 2019, 3:18 p.m.
function() {	chipx86	March 28, 2019, 2:20 p.m.
function() It's better to let beforeEach(), it(), describe(), etc. be multi-line anyway so it's less of a change to add …	chipx86	March 28, 2019, 2:20 p.m.
Col: 13 Do not use 'new' for side effects.	reviewbot	April 5, 2019, 11:24 a.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/utils/tests/keyBindingUtilsTests.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 19
 'view' is defined but never used.
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	d31cce47e2b4dac3726758579e581e5e4c3be4c5
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	e788f470b8d0d0f96805190a599adc1339a1fb10

Diff:

Revision 2 (+2452 -2910)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/collections/tests/filteredCollectionTests.js
	reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/paginationModelTests.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
	reviewboard/static/rb/js/models/tests/extraDataTests.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
	26 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/utils/tests/keyBindingUtilsTests.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 19
 'view' is defined but never used.
```
1. chipx86 March 28, 2019, 1:15 p.m.
  Let's fix this to just not assign to a variable.

reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewEntryViewTests.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Too many spaces.
```
reviewboard/static/rb/js/utils/tests/urlUtilsTests.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
function() {
```

reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

function()
It's better to let beforeEach(), it(), describe(), etc. be multi-line anyway so it's less of a change to add to them.

Commits:

	Summary	ID
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	e788f470b8d0d0f96805190a599adc1339a1fb10
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	ac15ce7c2d9fa1b27011a3a269b8ecbf1977a5f7

Diff:

Revision 3 (+2428 -2882)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/collections/tests/filteredCollectionTests.js
	reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/paginationModelTests.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
	reviewboard/static/rb/js/models/tests/extraDataTests.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
	26 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/utils/tests/keyBindingUtilsTests.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Col: 13
 Do not use 'new' for side effects.

chipx86 March 28, 2019, 4:06 p.m.
```
Doh. Come on, linter.
```

chipx86 March 28, 2019, 4:10 p.m.

You can assign to this. It's the context for the test (shared by the it and any beforeEach()). It'll at least avoid the linter being angry.

Commits:

	Summary	ID
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	ac15ce7c2d9fa1b27011a3a269b8ecbf1977a5f7
	Migrate some more code to ES6 (5). This change converts all remaining test code to ES6. Testing done: Ran js-tests.	087db3eb299015557b983157d04a6d638e8044b1

Diff:

Revision 4 (+2428 -2882)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/collections/tests/filteredCollectionTests.js
	reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/paginationModelTests.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
	reviewboard/static/rb/js/models/tests/extraDataTests.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
	26 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (af8c91a)