Migrate some more code to ES6 (5).

Review Request #10455 — Created March 20, 2019 and submitted

david
Review Board
release-4.0.x
reviewboard

This change converts all remaining test code to ES6.

Ran js-tests.

Summary
Migrate some more code to ES6 (5).
Description From Last Updated

Col: 19 'view' is defined but never used.

reviewbotreviewbot

Too many spaces.

chipx86chipx86

Col: 19 'view' is defined but never used.

reviewbotreviewbot

function() {

chipx86chipx86

function() It's better to let beforeEach(), it(), describe(), etc. be multi-line anyway so it's less of a change to add ...

chipx86chipx86

Col: 13 Do not use 'new' for side effects.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
Review request changed
chipx86
  1. 
      
  2. function()

    It's better to let beforeEach(), it(), describe(), etc. be multi-line anyway so it's less of a change to add to them.

  3. 
      
david
Review request changed
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (af8c91a)
Loading...