flake8
-
reviewboard/staticbundles.py (Diff revision 1) -
-
-
Review Request #10454 — Created March 20, 2019 and submitted
This change converts test code inside the resources/ directory to ES6.
Ran js-tests.
Summary | ID |
---|---|
deef6aa7777f0bc14cdefb4102f8fb8826c007a5 |
Description | From | Last Updated |
---|---|---|
Col: 9 Expected an assignment or function call and instead saw an expression. |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
For Jasmine, this should be preserved. It represents the text content. We don't want to use fat arrow functions in … |
chipx86 | |
Can you put parens around the calculations? It'll help with readability here. |
chipx86 | |
E501 line too long (89 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
This line's too long now. |
chipx86 | |
This line's too long now. |
chipx86 | |
This should be function() { |
chipx86 | |
function() |
chipx86 | |
E501 line too long (89 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot |
reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js (Diff revision 2) |
---|
For Jasmine,
this
should be preserved. It represents the text content. We don't want to use fat arrow functions in any call tosuite()
,beforeEach()
,it()
,describe()
, etc.
reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js (Diff revision 2) |
---|
Can you put parens around the calculations? It'll help with readability here.
Commits: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1368 -1766)
|
Commits: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1358 -1752)
|