Summary

Migrate some more code to ES6 (4).

Review Request #10454 — Created March 20, 2019 and submitted April 16, 2019, 3:05 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts test code inside the resources/ directory to ES6.

Testing Done

Ran js-tests.

Commits

Summary	ID
Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	deef6aa7777f0bc14cdefb4102f8fb8826c007a5

Issues

Description	From	Last Updated
Col: 9 Expected an assignment or function call and instead saw an expression.	reviewbot	March 20, 2019, 12:06 p.m.
E501 line too long (89 > 79 characters)	reviewbot	March 20, 2019, 12:04 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 20, 2019, 12:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 20, 2019, 12:04 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 20, 2019, 12:04 p.m.
For Jasmine, this should be preserved. It represents the text content. We don't want to use fat arrow functions in …	chipx86	March 22, 2019, 10:43 a.m.
Can you put parens around the calculations? It'll help with readability here.	chipx86	March 22, 2019, 10:43 a.m.
E501 line too long (89 > 79 characters)	reviewbot	March 20, 2019, 12:07 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 20, 2019, 12:07 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 20, 2019, 12:07 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 20, 2019, 12:07 p.m.
This line's too long now.	chipx86	March 28, 2019, 2:18 p.m.
This line's too long now.	chipx86	March 28, 2019, 2:18 p.m.
This should be function() {	chipx86	March 28, 2019, 2:18 p.m.
function()	chipx86	March 28, 2019, 2:19 p.m.
E501 line too long (89 > 79 characters)	reviewbot	March 22, 2019, 3:17 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 22, 2019, 3:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 22, 2019, 3:17 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 22, 2019, 3:17 p.m.
E501 line too long (89 > 79 characters)	reviewbot	March 28, 2019, 2:25 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 28, 2019, 2:25 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 28, 2019, 2:25 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 28, 2019, 2:25 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```

JSHint

reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 Expected an assignment or function call and instead saw an expression.
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	22c2620675f2f620b92d6b4a8d76238292584e90
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	1db504d5a5e587a9dfd9336d18199458576bdf5f

Diff:

Revision 2 (+2432 -2830)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentReplyModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
	reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.js
	17 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```

reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

For Jasmine, this should be preserved. It represents the text content. We don't want to use fat arrow functions in any call to suite(), beforeEach(), it(), describe(), etc.

reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Can you put parens around the calculations? It'll help with readability here.

Commits:

	Summary	ID
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	1db504d5a5e587a9dfd9336d18199458576bdf5f
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	c59c498620f9bab7e644a841fa84aa6ab71f4a07

Diff:

Revision 3 (+1368 -1766)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentReplyModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
	reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.js
	17 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/staticbundles.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```

Looks pretty good. Just a few small things from the undoing of () =>.

reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
This line's too long now.
```
reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
This line's too long now.
```
reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
This should be function() {
```
reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
function()
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	c59c498620f9bab7e644a841fa84aa6ab71f4a07
	Migrate some more code to ES6 (4). This change converts test code inside the resources/ directory to ES6. Testing done: Ran js-tests.	deef6aa7777f0bc14cdefb4102f8fb8826c007a5

Diff:

Revision 4 (+1358 -1752)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
	reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseCommentReplyModelTests.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
	reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.js
	17 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/staticbundles.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (1b452f5)