Explicitly order the commits in the CommitListField

 






 

 


  Review Request #10447
  —
  Created March 16, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The CommitListField previously retrieved the DiffCommit objects in

an unspecified order, which resulted in them sometimes being listed out

of order, specifically when a MySQL database was used. We now

explicitly order the query by the ID so that the commits will be

listed in creation order.

 








  


 
 

  

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Explicitly order the commits in the CommitListField
     
The `CommitListField` previously retrieved the `DiffCommit` objects in
an unspecified order, which resulted in them sometimes being listed out
of order, specifically when a MySQL database was used. We now
*explicitly* order the query by the ID so that the commits will be
listed in creation order.

    

   
  		
  40110a6ac0423fda10adf2046e1951265b19a6cd
  Barret Rennie
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/builtin_fields.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...