Explicitly order the commits in the CommitListField

Review Request #10447 — Created March 16, 2019 and submitted

Information
brennie
Review Board
release-4.0.x
Reviewers
reviewboard 
The CommitListField previously retrieved the DiffCommit objects in

an unspecified order, which resulted in them sometimes being listed out

of order, specifically when a MySQL database was used. We now

explicitly order the query by the ID so that the commits will be

listed in creation order.




 












 

  
  





 

   

   

 
 
  

    Summary

  

 
 

  


   

    
     
    

   

   
Explicitly order the commits in the CommitListField


  


 






 




 

 














  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




brennie




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-4.0.x (c085f6f)





 


 










  

 









     

    

   

  

  

   
   Loading...