Add modifiers to make config form containers flush against sides.

Review Request #10441 — Created March 7, 2019 and submitted

Information

Djblets
release-1.0.x

Reviewers

The config forms containers had a rule to remove the top/bottom margins
for the first/last .djblets-l-config-forms-container element within a
parent. This worked for the usage in RBCommons, where we wanted some
components (like lists) to appear toward the top/bottom of a box without
adding additional margins. This was done with :first-child and
:last-child rules, which didn't work unless the layout was just
right.

This change removes those rules and replaces them with new modifiers for
making the container flush against the top or bottom, which just removes
any margins/borders. This is easier to reason about and tweak in
consuming applications.

Tested this with some container usage for integrations, and played with
styles in the browser.

Summary ID
Add modifiers to make config form container flush against sides.
The config forms containers had a rule to remove the top/bottom margins for the first/last `.djblets-l-config-forms-container` element within a parent. This worked for the usage in RBCommons, where we wanted some components (like lists) to appear toward the top/bottom of a box without adding additional margins. This was done with `:first-child` and `:last-child` rules, which didn't work unless the layout was just right. This change removes those rules and replaces them with new modifiers for making the container flush against the top or bottom, which just removes any margins/borders. This is easier to reason about and tweak in consuming applications.
6a19ee3dc386063b8081177343fc703021c5893c
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (a9f1884)
Loading...