Add support for deleting integration configs from the list.

Review Request #10439 — Created March 5, 2019 and submitted

Information

Djblets
release-1.0.x

Reviewers

This redoes the management of the integration configuration list to make
use of the dynamic Config Forms list components. This allows us to
define a Delete action, which will delete the configuration and
automatically update the list. This is much easier than going into the
configuration page (assuming the configuration page offers a Delete
button).

This necessitated some changes to the loading of the page. Now, instead
of building the list up-front, we serialize the data for the UI, and
it's passed in through the Config Forms list machinery. While that's
loading, a "Loading integrations" spinner will be displayed, so the list
doesn't look empty.

Further changes will build on this to better construct the popup display.

Tested this in both the admin UI and in the RBCommons Team Admin UI.

Unit tests pass.

Summary ID
Add support for deleting integration configs from the list.
This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.
cd7db70c861c09778ac6c38ddeec85929805e4cd

Description From Last Updated

Should we preventDefault and stopPropagation on the click event?

daviddavid

Needs documentation for options.

daviddavid

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. Should we preventDefault and stopPropagation on the click event?

    1. Huh, I thought the base action code took care of this for us, but it doesn't. I'll fix this in that code separately.

  3. 
      
chipx86
Review request changed

Change Summary:

Added missing docs.

Commits:

Summary ID
Add support for deleting integration configs from the list.
This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.
392cf6e7ef70e9d9660943ceed1f58c950c07121
Add support for deleting integration configs from the list.
This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.
cd7db70c861c09778ac6c38ddeec85929805e4cd

Diff:

Revision 2 (+1044 -110)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (f70bddc)
Loading...