Summary

Add support for deleting integration configs from the list.

Review Request #10439 — Created March 5, 2019 and submitted March 10, 2019, 1:38 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This necessitated some changes to the loading of the page. Now, instead
of building the list up-front, we serialize the data for the UI, and
it's passed in through the Config Forms list machinery. While that's
loading, a "Loading integrations" spinner will be displayed, so the list
doesn't look empty.

Further changes will build on this to better construct the popup display.

Testing Done

Tested this in both the admin UI and in the RBCommons Team Admin UI.

Unit tests pass.

Commits

Summary	ID
Add support for deleting integration configs from the list. This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.	cd7db70c861c09778ac6c38ddeec85929805e4cd

Summary

Add support for deleting integration configs from the list.

This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.

cd7db70c861c09778ac6c38ddeec85929805e4cd

Files

Issues

Description	From	Last Updated
Should we preventDefault and stopPropagation on the click event?	david	March 6, 2019, 5:29 p.m.
Needs documentation for options.	david	March 6, 2019, 5:31 p.m.
E501 line too long (88 > 79 characters)	reviewbot	March 5, 2019, 3:31 a.m.
E501 line too long (88 > 79 characters)	reviewbot	March 6, 2019, 5:45 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```

djblets/static/djblets/js/integrations/views/integrationConfigListView.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

Should we preventDefault and stopPropagation on the click event?

chipx86 March 6, 2019, 5:29 p.m.

Huh, I thought the base action code took care of this for us, but it doesn't. I'll fix this in that code separately.

djblets/static/djblets/js/integrations/views/integrationConfigListView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs documentation for options.
```

Change Summary:

Added missing docs.

Commits:

	Summary	ID
	Add support for deleting integration configs from the list. This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.	392cf6e7ef70e9d9660943ceed1f58c950c07121
	Add support for deleting integration configs from the list. This redoes the management of the integration configuration list to make use of the dynamic Config Forms list components. This allows us to define a Delete action, which will delete the configuration and automatically update the list. This is much easier than going into the configuration page (assuming the configuration page offers a Delete button). This necessitated some changes to the loading of the page. Now, instead of building the list up-front, we serialize the data for the UI, and it's passed in through the Config Forms list machinery. While that's loading, a "Loading integrations" spinner will be displayed, so the list doesn't look empty. Further changes will build on this to better construct the popup display.	cd7db70c861c09778ac6c38ddeec85929805e4cd

Diff:

Revision 2 (+1044 -110)

Show changes

	djblets/staticbundles.py
	djblets/integrations/views.py
	djblets/integrations/templates/integrations/admin/integration_list.html
	djblets/integrations/templates/integrations/parts/integration_list.html
	djblets/static/djblets/css/config-forms.less
	djblets/static/djblets/css/integrations.less
	djblets/static/djblets/js/integrations/views/integrationConfigListView.es6.js
	djblets/static/djblets/js/integrations/views/tests/integrationConfigListViewTests.es6.js
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (f70bddc)