Summary

Fix a crash with missing review request IDs in the close-submitted hooks.

Review Request #10434 — Created Feb. 26, 2019 and submitted Feb. 27, 2019, 2:37 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The common close_all_review_requests() function for close-submitted

hooks attempted to log any review request IDs referenced in commits that

couldn't be found in the database. Part of this involved building a map

of the ones that could be found, but the code to do this was broken,

causing a crash.
This change fixes the crash, and adds new unit tests for the affected

services that verify things work correctly when encountering missing

review request IDs.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix a crash with missing review request IDs in the close-submitted hooks. The common `close_all_review_requests()` function for close-submitted hooks attempted to log any review request IDs referenced in commits that couldn't be found in the database. Part of this involved building a map of the ones that could be found, but the code to do this was broken, causing a crash. This change fixes the crash, and adds new unit tests for the affected services that verify things work correctly when encountering missing review request IDs.	74a9a02c02bc15a826436e488ea3c342de68975e

Summary

Fix a crash with missing review request IDs in the close-submitted hooks.

The common `close_all_review_requests()` function for close-submitted hooks attempted to log any review request IDs referenced in commits that couldn't be found in the database. Part of this involved building a map of the ones that could be found, but the code to do this was broken, causing a crash. This change fixes the crash, and adds new unit tests for the affected services that verify things work correctly when encountering missing review request IDs.

74a9a02c02bc15a826436e488ea3c342de68975e

Issues

Description	From	Last Updated
F841 local variable 'response' is assigned to but never used	reviewbot	Feb. 26, 2019, 5:56 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'response' is assigned to but never used
```

Change Summary:

Fixed an unused variable.

Commits:

	Summary	ID
	Fix a crash with missing review request IDs in the close-submitted hooks. The common `close_all_review_requests()` function for close-submitted hooks attempted to log any review request IDs referenced in commits that couldn't be found in the database. Part of this involved building a map of the ones that could be found, but the code to do this was broken, causing a crash. This change fixes the crash, and adds new unit tests for the affected services that verify things work correctly when encountering missing review request IDs.	33f79adeb118be38b6107c3cd325faf83e5e1082
	Fix a crash with missing review request IDs in the close-submitted hooks. The common `close_all_review_requests()` function for close-submitted hooks attempted to log any review request IDs referenced in commits that couldn't be found in the database. Part of this involved building a map of the ones that could be found, but the code to do this was broken, causing a crash. This change fixes the crash, and adds new unit tests for the affected services that verify things work correctly when encountering missing review request IDs.	74a9a02c02bc15a826436e488ea3c342de68975e

Diff:

Revision 2 (+388 -78)

Show changes

	reviewboard/hostingsvcs/hook_utils.py
	reviewboard/hostingsvcs/tests/test_bitbucket.py
	reviewboard/hostingsvcs/tests/test_github.py
	reviewboard/hostingsvcs/tests/test_rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (03874e0)