Fix a crash with missing review request IDs in the close-submitted hooks.

Review Request #10434 — Created Feb. 26, 2019 and submitted

Information

Review Board
release-3.0.x

Reviewers

The common close_all_review_requests() function for close-submitted
hooks attempted to log any review request IDs referenced in commits that
couldn't be found in the database. Part of this involved building a map
of the ones that could be found, but the code to do this was broken,
causing a crash.

This change fixes the crash, and adds new unit tests for the affected
services that verify things work correctly when encountering missing
review request IDs.

Unit tests pass.

Summary ID
Fix a crash with missing review request IDs in the close-submitted hooks.
The common `close_all_review_requests()` function for close-submitted hooks attempted to log any review request IDs referenced in commits that couldn't be found in the database. Part of this involved building a map of the ones that could be found, but the code to do this was broken, causing a crash. This change fixes the crash, and adds new unit tests for the affected services that verify things work correctly when encountering missing review request IDs.
74a9a02c02bc15a826436e488ea3c342de68975e
Description From Last Updated

F841 local variable 'response' is assigned to but never used

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (03874e0)