Fix a JavaScript crash in the diff viewer.

Review Request #10424 — Created Feb. 20, 2019 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

Some recent work to convert RB.PaginationView to ES6 resulted in a
const variable that was defined in one scope and accessed in another.
This resulted in a problem building URLs needed for pagination and
switching commits.

This change fixes up the scoping issues, and also fixes a check that
resulted in the wrong variable being accessed when determining the kind
of result to return.

Verified the regression, and tested with the fix. URL building and
links worked.

JavaScript unit tests pass.

Summary
Fix a JavaScript crash in the diff viewer.
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (0ce206c)
Loading...