Fix a JavaScript crash in the diff viewer.

Review Request #10424 — Created Feb. 20, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

Some recent work to convert RB.PaginationView to ES6 resulted in a
const variable that was defined in one scope and accessed in another.
This resulted in a problem building URLs needed for pagination and
switching commits.

This change fixes up the scoping issues, and also fixes a check that
resulted in the wrong variable being accessed when determining the kind
of result to return.

Verified the regression, and tested with the fix. URL building and
links worked.

JavaScript unit tests pass.

Summary ID
Fix a JavaScript crash in the diff viewer.
Some recent work to convert `RB.PaginationView` to ES6 resulted in a `const` variable that was defined in one scope and accessed in another. This resulted in a problem building URLs needed for pagination and switching commits. This change fixes up the scoping issues, and also fixes a check that resulted in the wrong variable being accessed when determining the kind of result to return.
1d6532d0d8a9f70b93d54a5f67fe27e23402dc92
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (0ce206c)