Summary

Migrate some more code to ES6 (3)

Review Request #10413 — Created Feb. 17, 2019 and submitted April 16, 2019, 3:05 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the remaining non-test code to ES6. This is just a
grab-bag of remaining files throughout the code.

Testing Done

Ran js-tests.

Commits

Summary	ID
Migrate some more code to ES6 (3) This change converts the remaining non-test code to ES6. This is just a grab-bag of remaining files throughout the code. Testing done: Ran js-tests.	5e83484bb6c85ad64911fb2fd5ab3ff7ae1bc2cf

Issues

Description	From	Last Updated
Can you make these single-quote strings while these lines are being changed?	chipx86	March 20, 2019, 10:43 a.m.
Maybe more work than you want to do here, but this would be simplified so much if we just calculated …	chipx86	March 20, 2019, 10:43 a.m.
Single quotes?	chipx86	March 20, 2019, 10:43 a.m.
$element	chipx86	March 20, 2019, 10:44 a.m.
Want to use template literals here?	chipx86	March 20, 2019, 10:44 a.m.
Single quotes?	chipx86	March 20, 2019, 10:44 a.m.
I feel like this reads a lot better the old way: $(...).on('click', () => { ... });	chipx86	March 20, 2019, 10:45 a.m.
Can the $( go on the second line?	chipx86	March 20, 2019, 10:45 a.m.
There's a space here.	chipx86	March 20, 2019, 10:45 a.m.
Can you switch these to this.listenTo() calls?	chipx86	March 20, 2019, 10:46 a.m.
This can move into the if. It's unused otherwise.	chipx86	March 20, 2019, 10:46 a.m.
MaMaMaMaMaMa	chipx86	March 20, 2019, 10:46 a.m.

flake8 passed.

JSHint internal error.

reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you make these single-quote strings while these lines are being changed?
```

reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

Maybe more work than you want to do here, but this would be simplified so much if we just calculated the admin-widgets vs admin-extras in the if and then just plugged that into the selector once, since the rest is all just copy/paste.

david March 20, 2019, 10:47 a.m.

Seeing as we're planning on making more changes to the dashboard soonish I'd rather hold off.

reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes?
```
reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
$element
```
reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Want to use template literals here?
```
reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes?
```

reviewboard/static/rb/js/admin/admin.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

I feel like this reads a lot better the old way:

$(...).on('click', () => {
    ...
});

reviewboard/static/rb/js/admin/repositoryform.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can the $( go on the second line?
```
reviewboard/static/rb/js/pages/views/dashboardView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
There's a space here.
```

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Can you switch these to this.listenTo() calls?

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This can move into the if. It's unused otherwise.
```
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
MaMaMaMaMaMa
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (3) This change converts the remaining non-test code to ES6. This is just a grab-bag of remaining files throughout the code. Testing done: Ran js-tests.	ffb6b4e8eabdacd8ca725d7dceed76b9559c30c8
	Migrate some more code to ES6 (3) This change converts the remaining non-test code to ES6. This is just a grab-bag of remaining files throughout the code. Testing done: Ran js-tests.	5e83484bb6c85ad64911fb2fd5ab3ff7ae1bc2cf

Diff:

Revision 2 (+1628 -1408)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/admin/admin.js
	reviewboard/static/rb/js/admin/repositoryform.js
	reviewboard/static/rb/js/admin/views/supportBannerView.js
	reviewboard/static/rb/js/admin/views/webhookFormView.js
	reviewboard/static/rb/js/configForms/base.js
	reviewboard/static/rb/js/extensions/models/aliases.js
	reviewboard/static/rb/js/pages/models/dashboardModel.js
	8 more

Checks run (1 succeeded, 1 failed with error)

flake8 passed.

JSHint internal error.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (30e618e)