flake8
passed.
JSHint
passed.
Fix emptying the draft target_groups list causing all entries to appear.
Review Request #10411 — Created Feb. 16, 2019 and submitted
The API for the review request draft was generating a query incorrectly.
Setting an emptytarget_groupsvalue would result in all available
groups on the global or Local Site to appear, meaning it was impossible
to clear out the list. This problem was specific totarget_groups,
though other fields (target_peopleanddepends_on) performed
effectively useless queries as well.This change fixes this to check whether the list of values is empty
before doing any real work. If it is empty, then empty values are
immediately returned.
Unit tests pass.
Reproduced the issue locally and verified the fix.
Change Summary:
Added one more unit test for
depends_on.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+88) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2) -
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2) E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2) E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2) E127 continuation line over-indented for visual indent
Change Summary:
Fixed some styling oopsies from a variable rename.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+88) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
