Fix emptying the draft target_groups list causing all entries to appear.

Review Request #10411 — Created Feb. 16, 2019 and submitted

chipx86
Review Board
release-3.0.x
4790
c7bb269...
reviewboard

The API for the review request draft was generating a query incorrectly.
Setting an empty target_groups value would result in all available
groups on the global or Local Site to appear, meaning it was impossible
to clear out the list. This problem was specific to target_groups,
though other fields (target_people and depends_on) performed
effectively useless queries as well.

This change fixes this to check whether the list of values is empty
before doing any real work. If it is empty, then empty values are
immediately returned.

Unit tests pass.

Reproduced the issue locally and verified the fix.

Description From Last Updated

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot
chipx86
Review request changed

Change Summary:

Added one more unit test for depends_on.

Commit:

-aa0aaf268d843dfc2a12cb6127863c369c2f0a70
+fed87af8213688a05f5e42da65aa51e65ec42d67

Diff:

Revision 2 (+88)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (bb3290c)
Loading...