Summary

Fix emptying the draft target_groups list causing all entries to appear.

Review Request #10411 — Created Feb. 16, 2019 and submitted Feb. 18, 2019, 5:44 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

4790

Depends On

Commit

c7bb269...

Reviewers

Groups

reviewboard

People

Description

The API for the review request draft was generating a query incorrectly.
Setting an empty target_groups value would result in all available
groups on the global or Local Site to appear, meaning it was impossible
to clear out the list. This problem was specific to target_groups,
though other fields (target_people and depends_on) performed
effectively useless queries as well.

This change fixes this to check whether the list of values is empty
before doing any real work. If it is empty, then empty values are
immediately returned.

Testing Done

Unit tests pass.

Reproduced the issue locally and verified the fix.

Issues

Description	From	Last Updated
E127 continuation line over-indented for visual indent	reviewbot	Feb. 16, 2019, 6:27 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 16, 2019, 5:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 16, 2019, 5:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 16, 2019, 5:55 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added one more unit test for depends_on.

Commit:

aa0aaf268d843dfc2a12cb6127863c369c2f0a70

fed87af8213688a05f5e42da65aa51e65ec42d67

Diff:

Revision 2 (+88)

Show changes

	reviewboard/webapi/resources/review_request_draft.py
	reviewboard/webapi/tests/test_review_request_draft.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

Change Summary:

Fixed some styling oopsies from a variable rename.

Commit:

fed87af8213688a05f5e42da65aa51e65ec42d67

c7bb2696cfb31d309a192fb7b44edfd12ec06960

Diff:

Revision 3 (+88)

Show changes

	reviewboard/webapi/resources/review_request_draft.py
	reviewboard/webapi/tests/test_review_request_draft.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (bb3290c)