Fish Trophy

david got a fish trophy!

Fix an IndexError for mercurial repositories with no bookmarks.

Review Request #10401 — Created Feb. 10, 2019 and submitted

david
rb-gateway
release-1.0.x
4792
e9aac9a...
rb-gateway

When a mercurial repository doesn't have any bookmarks defined, the way
we were iterating over them was attempting to process an empty record,
causing an IndexError when we couldn't properly split it. This change
fixes it to test for the empty record, and adds a unit test which
verifies correct behavior for hg repositories with no bookmarks.

Ran unit tests.

Description From Last Updated

Line seems a bit too long.

chipx86chipx86
chipx86
  1. 
      
  2. repositories/hg_test.go (Diff revision 1)
     
     

    Line seems a bit too long.

    1. Golang code doesn't have line length limits.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (3ba52ab)
Loading...