david got a fish trophy!

Summary

Fix an IndexError for mercurial repositories with no bookmarks.

Review Request #10401 — Created Feb. 10, 2019 and submitted Feb. 20, 2019, 11:37 a.m.

Information

Owner

david

Repository

rb-gateway

Branch

release-1.0.x

Bugs

4792

Depends On

Commit

e9aac9a...

Reviewers

Groups

rb-gateway

People

Description

When a mercurial repository doesn't have any bookmarks defined, the way
we were iterating over them was attempting to process an empty record,
causing an IndexError when we couldn't properly split it. This change
fixes it to test for the empty record, and adds a unit test which
verifies correct behavior for hg repositories with no bookmarks.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Line seems a bit too long.	chipx86	Feb. 17, 2019, 11:12 a.m.

flake8 passed.

JSHint passed.

Ship it!

repositories/hg_test.go (Diff revision 1)
The issue has been dropped. Show all issues
```
Line seems a bit too long.
```
1. david Feb. 17, 2019, 11:12 a.m.
  Golang code doesn't have line length limits.

Status:: Completed
Change Summary:: Pushed to release-1.0.x (3ba52ab)

repositories/hg_test.go (Diff revision 1)