flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js (Diff revision 1) Show all issues
Migrate some more code to ES6 (2).
Review Request #10400 — Created Feb. 8, 2019 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-4.0.x | |
| Reviewers | |
| reviewboard | |
This change converts remaining non-test code in the newReviewRequest/
directory to ES6.
Ran js-tests.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Col: 15 '$branch' is defined but never used. |
 reviewbot
|
|
|
Can we order this alphabetically? |
 chipx86
|
|
|
Looks like the description is indented too far. |
chipx86
|
|
|
The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the <span>? |
chipx86
|
|
|
Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the ... |
chipx86
|
|
|
Missing period, and you'll also need to escape the HTML tags. |
chipx86
|
|
|
HTML tag needs to be escaped. |
chipx86
|
|
|
Mind adding Model Attributes here? |
chipx86
|
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+866 -706) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.es6.js (Diff revision 2) Can we order this alphabetically?
-
reviewboard/static/rb/js/newReviewRequest/views/commitsView.es6.js (Diff revision 2) Looks like the description is indented too far.
-
reviewboard/static/rb/js/newReviewRequest/views/repositoryView.es6.js (Diff revision 2) The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the
<span>?
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+870 -706) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the old view".
Or just reference the view itself.
-
reviewboard/static/rb/js/newReviewRequest/views/branchView.es6.js (Diff revision 3) Missing period, and you'll also need to escape the HTML tags.
-
reviewboard/static/rb/js/newReviewRequest/views/branchesView.es6.js (Diff revision 3) HTML tag needs to be escaped.
-
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.