Migrate some more code to ES6 (2).

Review Request #10400 — Created Feb. 8, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

This change converts remaining non-test code in the newReviewRequest/
directory to ES6.

Ran js-tests.

Summary ID
Migrate some more code to ES6 (2).
This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.
31bc098fd6001a0fb6c3ebf75b759ae189649585
Description From Last Updated

Col: 15 '$branch' is defined but never used.

reviewbotreviewbot

Can we order this alphabetically?

chipx86chipx86

Looks like the description is indented too far.

chipx86chipx86

The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the <span>?

chipx86chipx86

Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the …

chipx86chipx86

Missing period, and you'll also need to escape the HTML tags.

chipx86chipx86

HTML tag needs to be escaped.

chipx86chipx86

Mind adding Model Attributes here?

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. 
      
  2. Can we order this alphabetically?

  3. Looks like the description is indented too far.

  4. The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the <span>?

  5. 
      
david
chipx86
  1. 
      
  2. Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the old view".

    Or just reference the view itself.

  3. Missing period, and you'll also need to escape the HTML tags.

  4. HTML tag needs to be escaped.

  5. Mind adding Model Attributes here?

  6. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (c7fa083)
Loading...