Summary

Migrate some more code to ES6 (2).

Review Request #10400 — Created Feb. 8, 2019 and submitted April 16, 2019, 3:05 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts remaining non-test code in the newReviewRequest/
directory to ES6.

Testing Done

Ran js-tests.

Commits

Summary	ID
Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	31bc098fd6001a0fb6c3ebf75b759ae189649585

Issues

Description	From	Last Updated
Col: 15 '$branch' is defined but never used.	reviewbot	Feb. 8, 2019, 2:49 p.m.
Can we order this alphabetically?	chipx86	Feb. 17, 2019, 11:41 a.m.
Looks like the description is indented too far.	chipx86	Feb. 17, 2019, 11:41 a.m.
The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the <span>?	chipx86	Feb. 17, 2019, 12:01 p.m.
Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the …	chipx86	March 8, 2019, 1:44 p.m.
Missing period, and you'll also need to escape the HTML tags.	chipx86	March 8, 2019, 1:44 p.m.
HTML tag needs to be escaped.	chipx86	March 8, 2019, 1:45 p.m.
Mind adding Model Attributes here?	chipx86	March 8, 2019, 1:46 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 '$branch' is defined but never used.
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	9c149a0a6c828b3be6336230e2c4f4c86b161b48
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	cd29bb7e0325842fa0b805be4e933e4ecfe97300

Diff:

Revision 2 (+866 -706)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/newReviewRequest/models/newReviewRequestModel.js
	reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
	reviewboard/static/rb/js/newReviewRequest/views/branchView.js
	reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
	reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Can we order this alphabetically?

reviewboard/static/rb/js/newReviewRequest/views/commitsView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Looks like the description is indented too far.
```
reviewboard/static/rb/js/newReviewRequest/views/repositoryView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
The line's pretty long now. Is there a change in appearance if there's whitespace surrounding the <span>?
```

Commits:

	Summary	ID
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	cd29bb7e0325842fa0b805be4e933e4ecfe97300
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	b65b355152e58ff78fe09c1a430383f3398c60dd

Diff:

Revision 3 (+870 -706)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/newReviewRequest/models/newReviewRequestModel.js
	reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
	reviewboard/static/rb/js/newReviewRequest/views/branchView.js
	reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
	reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/newReviewRequest/models/newReviewRequestModel.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Mind capitalizing as "New Review Request" view? That way, it doesn't read like "the new view" as opposed to "the old view".

Or just reference the view itself.

reviewboard/static/rb/js/newReviewRequest/views/branchView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing period, and you'll also need to escape the HTML tags.
```
reviewboard/static/rb/js/newReviewRequest/views/branchesView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
HTML tag needs to be escaped.
```

reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Mind adding Model Attributes here?

Commits:

	Summary	ID
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	b65b355152e58ff78fe09c1a430383f3398c60dd
	Migrate some more code to ES6 (2). This change converts remaining non-test code in the newReviewRequest/ directory to ES6. Testing done: Ran js-tests.	31bc098fd6001a0fb6c3ebf75b759ae189649585

Diff:

Revision 4 (+920 -748)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/newReviewRequest/models/newReviewRequestModel.js
	reviewboard/static/rb/js/newReviewRequest/models/newReviewRequestModel.es6.js
	reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
	reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/branchView.js
	reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitView.js
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (c7fa083)