flake8
passed.
JSHint
passed.
Review Request #10393 — Created Jan. 26, 2019 and updated
Information | |
---|---|
easyb | |
Review Board | |
release-3.0.x | |
46ef38e... | |
Reviewers | |
reviewboard | |
E.g. after a database import the SCM repository passwords can no longer be decrypted. This would lead to an exception when trying to decode the password to UTF-8. Instead, `Repository._get_password()` will now return `None` resulting in requiring the user to reset the password.
mysqldump --all-databases
Testing Done: |
|
---|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+118 -3) |
reviewboard/scmtools/crypto_utils.py (Diff revision 2) |
---|
F841 local variable 'e' is assigned to but never used
reviewboard/scmtools/errors.py (Diff revision 2) |
---|
If we would want to have here
(...) for repository %d
, we would need to pass the Repository model's ID to the constructor, right? We do not have that information where the exception is raised...
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+120 -3) |