Summary

Improve the error details when accessing missing resource attributes.

Review Request #10383 — Created Jan. 14, 2019 and submitted Jan. 23, 2019, 5:32 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

When attempting to access an attribute that doesn't exist on a resource,
the caller would just get a plain AttributeError. Left uncaught, this
would be displayed to the user, making it very hard to report anything
meaningful.

This change adds explicit error information containing the attribute
being requested and the resource it's being requested on.

Testing Done

Used this to diagnose a separate problem. Saw the enhanced error details.

Commits

Summary	ID
Improve the error details when accessing missing resource attributes. When attempting to access an attribute that doesn't exist on a resource, the caller would just get a plain `AttributeError`. Left uncaught, this would be displayed to the user, making it very hard to report anything meaningful. This change adds explicit error information containing the attribute being requested and the resource it's being requested on.	f0ab84957fdf4837bbf79e14d223b115d75ecab6

Summary

Improve the error details when accessing missing resource attributes.

When attempting to access an attribute that doesn't exist on a resource, the caller would just get a plain `AttributeError`. Left uncaught, this would be displayed to the user, making it very hard to report anything meaningful. This change adds explicit error information containing the attribute being requested and the resource it's being requested on.

f0ab84957fdf4837bbf79e14d223b115d75ecab6

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (a739e26)