flake8
passed.
JSHint
passed.
Add new icons
Review Request #10347 — Created Dec. 5, 2018 and discarded
Added new icons to the sprite sheet, shown in the attached image, that
will be used in the Unified Review Banner project. The new icons that
have been added are as follows:
- Draft Reply: can be used to show that there are draft replies to review
comments. - File: can be used to show that there are files affected in the review,
for example, the number of files with comments in a review. - Review: can be used to show that there is a review that is currently
in progress. - Create Review: can be used to show that a review can be created.
- Edit Review: can be used to show that a review that can be edited.
Manual testing to ensure that the icons show up correctly when the new
CSS classes for each is used (screenshot in the attached image shows the
results of this test).All JS tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Can you flesh out the summary to describe what the icons are for? And keep the commit message to ~70 … |
 chipx86
|
-
-
Can you flesh out the summary to describe what the icons are for? And keep the commit message to ~70 chars per line?
Going over each of the new icons in the description will help too. Remember that the goal is to make sure people can clearly understand the purpose of the change without having to open it to inspect the diff.
- Description:
-
~ Added new icons to the sprite sheet, shown in the attached image, that will be used in the Unified Review Banner project.
~ Added new icons to the sprite sheet, shown in the attached image, that
+ will be used in the Unified Review Banner project. The new icons that + have been added are as follows: + + - Draft Reply: can be used to show that there are draft replies to review
comments.
+ - File: can be used to show that there are files affected in the review,
for example, the number of files with comments in a review.
+ - Review: can be used to show that there is a review that is currently
in progress.
+ - Create Review: can be used to show that a review can be created.
+ - Edit Review: can be used to show that a review that can be edited.
- Draft Reply: can be used to show that there are draft replies to review
- Testing Done:
-
~ Manual testing to ensure that the icons show up correctly when the new CSS classes for each is used.
~ Manual testing to ensure that the icons show up correctly when the new
+ CSS classes for each is used (screenshot in the attached image shows the + results of this test). All JS tests pass.
