[WIP] Allowing the Comment Dialog to be Embeddable
Review Request #10341 — Created Dec. 3, 2018 and updated — Latest diff uploaded
Currently the entirety of the Comment Dialog lives inside of
RB.CommentDialogView. This patch will extract the internals of the
dialog, such as the text area and UI for checkboxes, and place them
inside ofRB.CommentPaneView.So far I have rendered a new view inside of the original
RB.CommentDialogViewfile,CommentPaneView, in order to get
comfortable with Backbone Views. I plan on filling out this new view
entirely before moving the Backbone view inside of a new file.
Diff Revision 3
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
orig
1
2
3
4
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/css/pages/reviews.less |
|---|
| reviewboard/static/rb/js/views/commentDialogView.es6.js |
|---|
| reviewboard/static/rb/js/views/commentPaneView.es6.js |
|---|