Status: Discarded
Change Summary:
Looks like my changes got rolled into this one, so I'm discarding this one
Review Request #10341 — Created Dec. 3, 2018 and updated
Information | |
---|---|
Sudolicious | |
Review Board | |
master | |
b267344... | |
Reviewers | |
reviewboard, students | |
Currently the entirety of the Comment Dialog lives inside of
RB.CommentDialogView
. This patch will extract the internals of the
dialog, such as the text area and UI for checkboxes, and place them
inside ofRB.CommentPaneView
.So far I have rendered a new view inside of the original
RB.CommentDialogView
file,CommentPaneView
, in order to get
comfortable with Backbone Views. I plan on filling out this new view
entirely before moving the Backbone view inside of a new file.
Description | From | Last Updated |
---|---|---|
You have some trailing whitespace here |
|
|
Col: 7 'CommentPaneView' was used before it was defined. |
![]() |
|
Col: 37 Missing semicolon. |
![]() |
|
Trailing whitespace |
|
|
Trailing whitespace |
|
|
trailing whitespace |
|
|
trailing whitespace |
|
|
trailing whitespace |
|
|
trailing whitespace |
|
|
trailing whitespace |
|
|
Col: 40 Missing semicolon. |
![]() |
|
Col: 70 Missing semicolon. |
![]() |
|
Col: 15 'userSession' is defined but never used. |
![]() |
|
Col: 15 'reviewRequest' is defined but never used. |
![]() |
|
Col: 15 'reviewRequestEditor' is defined but never used. |
![]() |
|
Col: 40 Missing semicolon. |
![]() |
|
Col: 47 Missing semicolon. |
![]() |
|
Col: 37 Missing semicolon. |
![]() |
|
Col: 56 Missing semicolon. |
![]() |
|
Col: 66 Missing semicolon. |
![]() |
|
Col: 55 Missing semicolon. |
![]() |
|
Col: 43 Missing semicolon. |
![]() |
|
Col: 45 Missing semicolon. |
![]() |
|
Col: 33 Missing semicolon. |
![]() |
|
Col: 40 Missing semicolon. |
![]() |
|
Col: 47 Missing semicolon. |
![]() |
|
Col: 37 Missing semicolon. |
![]() |
|
Col: 43 Missing semicolon. |
![]() |
|
Col: 33 Missing semicolon. |
![]() |
|
Col: 37 Missing semicolon. |
![]() |
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 1 (+104 -5) |
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 1) |
---|
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 1) |
---|
Col: 37 Missing semicolon.
reviewboard/static/rb/css/pages/reviews.less (Diff revision 1) |
---|
overflow: scroll will affect enables scroll both vertically and horizontally. You might want to be specific here.
reviewboard/static/rb/css/pages/reviews.less (Diff revision 1) |
---|
You have some trailing whitespace here
Added the TextEditor to the Pane I am implementing
Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+244 -13) |
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2) |
---|
Col: 40 Missing semicolon.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2) |
---|
Col: 70 Missing semicolon.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2) |
---|
Col: 15 'userSession' is defined but never used.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2) |
---|
Col: 15 'reviewRequest' is defined but never used.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2) |
---|
Col: 15 'reviewRequestEditor' is defined but never used.
Moved the Pane inside of a new file
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+507 -16) |
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 3) |
---|
Col: 40 Missing semicolon.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 3) |
---|
Col: 47 Missing semicolon.
Save functionality can work now.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+508 -16) |
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 4) |
---|
Col: 40 Missing semicolon.
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 4) |
---|
Col: 47 Missing semicolon.