[WIP] Allowing the Comment Dialog to be Embeddable

Review Request #10341 — Created Dec. 3, 2018 and updated

Sudolicious
Review Board
master
b267344...
reviewboard, students

Currently the entirety of the Comment Dialog lives inside of
RB.CommentDialogView. This patch will extract the internals of the
dialog, such as the text area and UI for checkboxes, and place them
inside of RB.CommentPaneView.

So far I have rendered a new view inside of the original
RB.CommentDialogView file, CommentPaneView, in order to get
comfortable with Backbone Views. I plan on filling out this new view
entirely before moving the Backbone view inside of a new file.



Description From Last Updated

You have some trailing whitespace here

bolariinwabolariinwa

Col: 7 'CommentPaneView' was used before it was defined.

reviewbotreviewbot

Col: 37 Missing semicolon.

reviewbotreviewbot

Trailing whitespace

bolariinwabolariinwa

Trailing whitespace

bolariinwabolariinwa

trailing whitespace

bolariinwabolariinwa

trailing whitespace

bolariinwabolariinwa

trailing whitespace

bolariinwabolariinwa

trailing whitespace

bolariinwabolariinwa

trailing whitespace

bolariinwabolariinwa

Col: 40 Missing semicolon.

reviewbotreviewbot

Col: 70 Missing semicolon.

reviewbotreviewbot

Col: 15 'userSession' is defined but never used.

reviewbotreviewbot

Col: 15 'reviewRequest' is defined but never used.

reviewbotreviewbot

Col: 15 'reviewRequestEditor' is defined but never used.

reviewbotreviewbot

Col: 40 Missing semicolon.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 37 Missing semicolon.

reviewbotreviewbot

Col: 56 Missing semicolon.

reviewbotreviewbot

Col: 66 Missing semicolon.

reviewbotreviewbot

Col: 55 Missing semicolon.

reviewbotreviewbot

Col: 43 Missing semicolon.

reviewbotreviewbot

Col: 45 Missing semicolon.

reviewbotreviewbot

Col: 33 Missing semicolon.

reviewbotreviewbot

Col: 40 Missing semicolon.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 37 Missing semicolon.

reviewbotreviewbot

Col: 43 Missing semicolon.

reviewbotreviewbot

Col: 33 Missing semicolon.

reviewbotreviewbot

Col: 37 Missing semicolon.

reviewbotreviewbot
Sudolicious
Sudolicious
Review request changed

Status: Re-opened

Summary:

-[WIP] Docking the Comment Dialog when scrolling
+[WIP] Allowing the Comment Dialog to be Embeddable

Description:

~  

Added current progress on keeping the commentDialog fixed to the page

~  
~  

~  
~  

Trying out Mike's fix for my issue, but it doesnt seem to solve my problem

~  
~  

~  
~  

Mikes Fix did it, I think theres still a slight bug but I will look into tommorrow

  ~

Currently the entirety of the Comment Dialog lives inside of

  ~ RB.CommentDialogView. This patch will extract the internals of the
  ~ dialog, such as the text area and UI for checkboxes, and place them
  ~ inside of RB.CommentPaneView.

  ~
  ~

So far I have rendered a new view inside of the original

  ~ RB.CommentDialogView file, CommentPaneView, in order to get
  ~ comfortable with Backbone Views. I plan on filling out this new view
  ~ entirely before moving the Backbone view inside of a new file.

-  
-  

-  
-  

Added a fix to keep the comment dialog contained on the page, otherwise it would break, Also added a pixel offset that would happend when the mouse is clicked

-  
-  

-  
-  

I've contained the comment dialog to the page, and I have fixed bugs that were happening because wouldn't detect

-  
-  

-  
-  

Commented the functions that I added to the file

-  
-  

-  
-  

Edited the previous Comments

-  
-  

-  
-  

Updated the less file in order to get rid of the 8px top-margin

-  
-  

-  
-  

Addressing some of Barrets comments

-  
-  

-  
-  

Addressing some of Barret's comments

-  
-  

-  
-  

Got rid of some semicolons pointed out by reviewbot

-  
-  

-  
-  

Creating the New Comment Pane view inside of the original Comment Dialog View file

Diff:

Revision 1 (+104 -5)

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

bolariinwa
  1. 
      
  2. overflow: scroll will affect enables scroll both vertically and horizontally. You might want to be specific here.

    1. Thats a good point, Thanks Bola.

  3. You have some trailing whitespace here

  4. Trailing whitespace

  5. Trailing whitespace

  6. trailing whitespace

  7. trailing whitespace

  8. trailing whitespace

  9. trailing whitespace

  10. trailing whitespace

  11. 
      
Sudolicious
Review request changed

Change Summary:

Added the TextEditor to the Pane I am implementing

Commit:

+c0b676e9d41c338c31a471c5a471bbceeb6a16ac

Diff:

Revision 2 (+244 -13)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

Sudolicious
Review request changed

Change Summary:

Moved the Pane inside of a new file

Commit:

-c0b676e9d41c338c31a471c5a471bbceeb6a16ac
+aa58773b80c7a8388bc0f4bcd4433674628f9ba5

Diff:

Revision 3 (+507 -16)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

Sudolicious
Review request changed

Change Summary:

Save functionality can work now.

Commit:

-aa58773b80c7a8388bc0f4bcd4433674628f9ba5
+b267344557cd187e0239c3ed3d409ab8b6375d22

Diff:

Revision 4 (+508 -16)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

Loading...