Summary

[WIP] Allowing the Comment Dialog to be Embeddable

Review Request #10341 — Created Dec. 3, 2018 and updated Dec. 14, 2018, 5:02 p.m.

Information

Owner

Sudolicious

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

b267344...

Reviewers

Groups

reviewboard, students

People

Description

Currently the entirety of the Comment Dialog lives inside of
RB.CommentDialogView. This patch will extract the internals of the
dialog, such as the text area and UI for checkboxes, and place them
inside of RB.CommentPaneView.

So far I have rendered a new view inside of the original
RB.CommentDialogView file, CommentPaneView, in order to get
comfortable with Backbone Views. I plan on filling out this new view
entirely before moving the Backbone view inside of a new file.

Testing Done

Issues

Description	From	Last Updated
You have some trailing whitespace here	bolariinwa	Dec. 8, 2018, 3:27 p.m.
Col: 7 'CommentPaneView' was used before it was defined.	reviewbot	Dec. 8, 2018, 3:30 p.m.
Col: 37 Missing semicolon.	reviewbot	Dec. 8, 2018, 3:30 p.m.
Trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
Trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
trailing whitespace	bolariinwa	Dec. 8, 2018, 3:27 p.m.
Col: 40 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:01 p.m.
Col: 70 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:01 p.m.
Col: 15 'userSession' is defined but never used.	reviewbot	Dec. 14, 2018, 4:02 p.m.
Col: 15 'reviewRequest' is defined but never used.	reviewbot	Dec. 14, 2018, 4:02 p.m.
Col: 15 'reviewRequestEditor' is defined but never used.	reviewbot	Dec. 14, 2018, 4:02 p.m.
Col: 40 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 47 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 37 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 56 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 66 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 55 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 43 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 45 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 33 Missing semicolon.	reviewbot	Dec. 14, 2018, 4:15 p.m.
Col: 40 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.
Col: 47 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.
Col: 37 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.
Col: 43 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.
Col: 33 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.
Col: 37 Missing semicolon.	reviewbot	Dec. 14, 2018, 5:02 p.m.

Status:: Discarded
Change Summary:: Looks like my changes got rolled into this one, so I'm discarding this one

Status:: Re-opened
Summary:: [WIP] Docking the Comment Dialog when scrolling
[WIP] Allowing the Comment Dialog to be Embeddable
Description:: ~
Added current progress on keeping the commentDialog fixed to the page
~
Currently the entirety of the Comment Dialog lives inside of
+ RB.CommentDialogView. This patch will extract the internals of the
+ dialog, such as the text area and UI for checkboxes, and place them
+ inside of RB.CommentPaneView.

~
~
~
Trying out Mike's fix for my issue, but it doesnt seem to solve my problem
~
~
So far I have rendered a new view inside of the original
~ RB.CommentDialogView file, CommentPaneView, in order to get
~ comfortable with Backbone Views. I plan on filling out this new view
~ entirely before moving the Backbone view inside of a new file.
-
-
-
Mikes Fix did it, I think theres still a slight bug but I will look into tommorrow
-
-
-
-
Added a fix to keep the comment dialog contained on the page, otherwise it would break, Also added a pixel offset that would happend when the mouse is clicked
-
-
-
-
I've contained the comment dialog to the page, and I have fixed bugs that were happening because wouldn't detect
-
-
-
-
Commented the functions that I added to the file
-
-
-
-
Edited the previous Comments
-
-
-
-
Updated the less file in order to get rid of the 8px top-margin
-
-
-
-
Addressing some of Barrets comments
-
-
-
-
Addressing some of Barret's comments
-
-
-
-
Got rid of some semicolons pointed out by reviewbot
-
-
-
-
Creating the New Comment Pane view inside of the original Comment Dialog View file
Diff:: Revision 1 (+104 -5)

reviewboard/static/rb/css/pages/reviews.less
reviewboard/static/rb/js/views/commentDialogView.es6.js
reviewboard/static/rb/js/views/commentPaneView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 7
 'CommentPaneView' was used before it was defined.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 37
 Missing semicolon.
```

reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)

overflow: scroll will affect enables scroll both vertically and horizontally. You might want to be specific here.

Sudolicious Dec. 8, 2018, 3:29 p.m.
```
Thats a good point, Thanks Bola.
```

reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)
The issue has been resolved. Show all issues
```
You have some trailing whitespace here
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```

Change Summary:

Added the TextEditor to the Pane I am implementing

Commit:

c0b676e9d41c338c31a471c5a471bbceeb6a16ac

Diff:

Revision 2 (+244 -13)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/static/rb/js/views/commentPaneView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 40
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 70
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 15
 'userSession' is defined but never used.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 15
 'reviewRequest' is defined but never used.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 15
 'reviewRequestEditor' is defined but never used.
```

Change Summary:

Moved the Pane inside of a new file

Commit:

c0b676e9d41c338c31a471c5a471bbceeb6a16ac

aa58773b80c7a8388bc0f4bcd4433674628f9ba5

Diff:

Revision 3 (+507 -16)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/static/rb/js/views/commentPaneView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 40
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 47
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 37
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 56
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 66
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 55
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 43
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 45
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 33
 Missing semicolon.
```

Change Summary:

Save functionality can work now.

Commit:

aa58773b80c7a8388bc0f4bcd4433674628f9ba5

b267344557cd187e0239c3ed3d409ab8b6375d22

Diff:

Revision 4 (+508 -16)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/static/rb/js/views/commentPaneView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 40
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentDialogView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 47
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 37
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 43
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 33
 Missing semicolon.
```
reviewboard/static/rb/js/views/commentPaneView.es6.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 37
 Missing semicolon.
```

~		Added current progress on keeping the commentDialog fixed to the page
	~	Currently the entirety of the Comment Dialog lives inside of
	+	`RB.CommentDialogView`. This patch will extract the internals of the
	+	dialog, such as the text area and UI for checkboxes, and place them
	+	inside of `RB.CommentPaneView`.

~
~
~		Trying out Mike's fix for my issue, but it doesnt seem to solve my problem
~
	~	So far I have rendered a new view inside of the original
	~	`RB.CommentDialogView` file, `CommentPaneView`, in order to get
	~	comfortable with Backbone Views. I plan on filling out this new view
	~	entirely before moving the Backbone view inside of a new file.
-
-
-		Mikes Fix did it, I think theres still a slight bug but I will look into tommorrow
-
-
-
-		Added a fix to keep the comment dialog contained on the page, otherwise it would break, Also added a pixel offset that would happend when the mouse is clicked
-
-
-
-		I've contained the comment dialog to the page, and I have fixed bugs that were happening because wouldn't detect
-
-
-
-		Commented the functions that I added to the file
-
-
-
-		Edited the previous Comments
-
-
-
-		Updated the less file in order to get rid of the 8px top-margin
-
-
-
-		Addressing some of Barrets comments
-
-
-
-		Addressing some of Barret's comments
-
-
-
-		Got rid of some semicolons pointed out by reviewbot
-
-
-
-		Creating the New Comment Pane view inside of the original Comment Dialog View file